RFC: opal_clock_gettime() and opal_clock_getres() #9798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
force-pushed
the
pr/opal-clock-gettime
branch
from
350cea8 to
1aace96
Compare
|
bot:ompi:retest |
1 similar comment
|
bot:ompi:retest |
As of Dec 2021, it turns out that CLOCK_MONOTONIC can actually go backwards on macOS (!). Add two simple portable wrappers that use CLOCK_MONOTONIC_RAW on Darwin (which doesn't go backwards) and CLOCK_MONOTONIC everywhere else. Additionally, if the underlying OS does not have clock_gettime(), use gettimeofday() instead. Signed-off-by: Jeff Squyres <[email protected]>
Update MPI_Wtick and MPI_Wtime to use the portable wrappers opal_clock_gettime() and opal_clock_getres(). Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/opal-clock-gettime
branch
from
1aace96 to
e72b4e6
Compare
|
@bwbarrett I changed the first commit:
|
bwbarrett
approved these changes
Jan 3, 2022
|
I talked this PR through with @bosilca verbally today, and he's ok with it. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an RFC for simple portable wrappers around clock_gettime(3) and clock_getres(3) (and falling back to gettimeofday(3) if clock_gettime is not available).
This PR came out of the discussion here and here (which have additional links to other and older conversations).
If this RFC is accepted, #8057 should be updated to use
opal_clock_gettime()andopal_clock_getres().